chore: upgrade to go 1.26#610
Conversation
There was a problem hiding this comment.
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 137 137
Lines 11092 11092
=======================================
Hits 8989 8989
Misses 1677 1677
Partials 426 426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
schedule/handler_darwin.go:180
- This preallocates
jobswith a hard-coded capacity of 10. Since the final size depends onsystemJobsanduserJobs, either avoid the magic number (let append grow), or compute capacity after fetching both slices (len(systemJobs)+len(userJobs)) to keep the allocation aligned with actual data.
func (h *HandlerLaunchd) Scheduled(profileName string) ([]Config, error) {
jobs := make([]Config, 0, 10)
if profileName == "" {
profileName = "*"
} else {
profileName = strings.ToLower(profileName)
}
// system jobs
systemJobs := h.getScheduledJob(profileName, constants.SchedulePermissionSystem)
jobs = append(jobs, systemJobs...)
// user jobs
userJobs := h.getScheduledJob(profileName, constants.SchedulePermissionUser)
jobs = append(jobs, userJobs...)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: upgrade to Go 1.26
Upgrades the Go toolchain from 1.25.8 to 1.26.1 and updates the build toolchain accordingly.
Toolchain changes:
go 1.26.1golangci-lint-v2)~> v2instead oflatestin CI workflowsGOCMDto usecommand -v goand corrected theGOPATHcheck in the MakefileLint fixes (prompted by updated linter rules):
convertDaysOfMonth) and added test coverage for it.Error()string comparison